[docs-infra] Fix emphasized code loading state#4659
Merged
dav-is merged 12 commits intomui:masterfrom Apr 28, 2026
Merged
Conversation
dav-is
added
type: bug
commit: |
Bundle size
PerformanceTotal duration: 1,276.76 ms ▼-324.09 ms(-20.2%) | Renders: 53 (+0) | Paint: 1,986.17 ms ▼-450.70 ms(-18.5%)
...and 7 more. View full report Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
dav-is
changed the title
github-actions
Bot
added
the
PR: out-of-date
github-actions
Bot
removed
the
PR: out-of-date
dav-is
requested review from
atomiks,
colmtuite,
flaviendelangle and
michaldudak
as code owners
1 task
Member
aarongarciah
left a comment
aarongarciah
left a comment
There was a problem hiding this comment.
Not sure if it's meant to be used like this, but nesting word highlighting in nested highlighted lines breaks the line highlighting:
/* @highlight-start */
&[data-starting-style],
&[data-ending-style] {
/* @highlight-start */
opacity: 0;
transform: scale(0.9); /* @highlight-text "transform" */
/* @highlight-end */
}
/* @highlight-end */
Member
Author
|
@aarongarciah that looks like a bug, thanks for mentioning, I'll draft a fix Edit: PR |
github-actions
Bot
added
the
PR: out-of-date
github-actions
Bot
removed
the
PR: out-of-date
Member
Author
|
@aarongarciah the issue is fixed now 
|
aarongarciah
approved these changes
Apr 28, 2026
oliviertassinari
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Upstream PR: mui/mui-public#1303
Preview Deploy
Emphasized lines (blue background
// @highlight) are not appearing on first render, despite being markedhighlightAt: 'init':After:
Also, emphasized lines are always shown on first render, even with
highlightAt: 'idle'to avoid a large blue flashCloses: #4653